Jon Brandvein

Results 172 comments of Jon Brandvein

Thanks a lot for the PR Fahrzin! It doesn't surprise me that people would want to customize the stub script, but I do wonder what all the use cases are...

@kwatts, @benley, @fahhem: What are the exact kinds of customization people want for the stub template? It's hard for me to imagine that users should be able to manipulate the...

@laszlocsomor: Does that mean the windows-specific logic in [python_stub_template.txt](https://github.com/bazelbuild/bazel/blob/ef0024b831a71521390dcb837b24b86485e5998d/src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt) is dead code and can be removed?

Thanks for the clarification. So if we go ahead with this, I won't distinguish the case of windows vs unix.

Please see design doc posted [here](https://github.com/bazelbuild/rules_python/blob/master/proposals/2018-11-08-customizing-the-python-stub-template.md), and in particular the open questions.

I'm not working on Python rules anymore. Ccing @rickeylev for any decisions regarding prioritization of this.

I mailed #99 for `--incompatible_disallow_legacy_py_provider` (before I saw this thread).

Hi Lisa, that certainly sounds problematic. The lack of an informative error message should be fixed as of bazelbuild/bazel@9f60686cf83957cc108f17d36b0a25119fdca37b, but that commit isn't in 4.0.0 (see bazelbuild/bazel#13077). Can you try...

[Bazel 4.0.0](https://github.com/bazelbuild/bazel/commit/6b33bdb1e22514304c0e35ce8e067f2175685245) has baseline bazelbuild/bazel@37a429ad12b4c9e6a62dbae4881a1ff03b81ab40, from Nov 18. The error message commit came during the (rather long, it seems) canarying period.

So to confirm, a build of Bazel containing the Jan 7 fix for better error reporting in Stardoc still fails to give a useful error message for why Stardoc now...