Kuan-Po Tseng
Kuan-Po Tseng
gentle ping @hashhar, could you take a look ? Many thanks
> I'd prefer to follow the following steps: > - Improve CollationAwareQueryBuilder so that it only applies COLLATE for inequalities (to not introduce performance degradation for equalities) > - Remove...
BTW if we don't do collation push down for equalities, in some cases join push down won't take effect e.g. copy tpch table orders and lineitem in mysql and run...
> When upgrading a Harvester cluster from v1.2-head -> v1.3-head with custom version.yaml object for Version CRD in harvester-system namespace - the Download Upgrade Image will continue to loop, not...
> This is more a design and behavioural question than a code review. Should we not have a similar behaviour as we have on the admission controller and allow specifying...
I also have another minor question: should we consider renaming these two settings (admissionController.filtering.defaultQueueName and admissionController.filtering.generateUniqueAppId)? Since they not only control the admission controller but also influence K8Shim, perhaps a...
gentle ping @wilfred-s I'm trying to follow the logic of `GenerateUniqueAppIds` and add a new variable `DefaultQueueName` in schedulerconf.go. However, I encountered a challenge. I believe DefaultQueueName must be placed...
gentle ping @irishgordo, though https://github.com/harvester/harvester/pull/5700 was merged in branch v1.3, it was not included in v1.3.0 release. Perhaps you can try upgrade from v1.3-head to master
gentle ping @raulgarbouzenitech, I closed this pull request since the timeout block was added in https://github.com/harvester/terraform-provider-harvester/pull/97. If you have any other questions, feel free to ask. Thanks! 😃