Dennis Brakhane
Dennis Brakhane
An alternative would be to just use one mutex, of course
It doesn't seem like using just a single mutex has any negative performance impact, so I've changed the code to use just one.
> This is not good, this part of code must absolutely not have any mutex locks. I never had a crash with this, as the whole map is being populated...
> As my second comment, would it help if we just use the safer find() method of the map and return nullptr if element is not found? iterators are invalidated...
Since you've found the underlying cause of the bug, this is not necessary anymore.
You can just look at [bae5ba4](https://github.com/turanszkij/WickedEngine/pull/904/commits/bae5ba4bdb67dffc2872639887abeb9c55edfcfd), it only has the proposed config.
> It should only work for the lines anybody modifies in the future, it shouldn't reformat a lot of existing code, especially third party files. The only other changes in...
@VinnyVicious It's a lot easier to exclude one commit from bisect/diff whatever than you think. Also, as I've said, it's not feasible to adjust code style changes only in changed...
> Also it doesn't have multiple clang format files, just one in the root directory. Be aware that this will cause the format rules to also get applied to files...
I believe it's basically a bug in Jolt, the recommended way of cleaning up will cause Jolt to do a double free once it's closing itself. Creating a bug report...