Brett Graham
Brett Graham
I'm closing this PR. The pytest plugin lacks unit tests. I think it makes sense to first consider adding tests for the plugin to verify changes (like those in this...
converted to draft until https://github.com/asdf-format/asdf/pull/1733#discussion_r1555834679 is addressed
The following branch of `roman_datamodels` adds `lazy` to the node converters (and makes some minor node changes to account for `AsdfDictNode` not passing `isinstance(..., dict)` etc) to allow lazy loading...
JWST regtests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1571/ passed with 2 unrelated (and common random) failures romancal regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/9746576095 (I ran the romancal tests with `photutils==1.12.0` since 1.13.0 is currently breaking main: https://github.com/spacetelescope/romancal/pull/1291) ran with...
@nden @perrygreenfield the regtests all pass with this PR (except for the 2 jwst tests that randomly and frequently fail).
Thanks for giving it a try. What file did you use for testing? If it's a roman file things will behave differently if you're using roman_datamodels main vs the "lazy"...
Thanks! I updated the `lazy_tree` documentation in: 5843adaac595cc77c2ff5633d2709fcd08db6cbc Does the updated description sound good? (emphasis added to the new part below, see the commit for the full text and context)....
Closing as the required PR https://github.com/asdf-format/asdf-standard/pull/415 was closed. It may be worth revisiting this in the future but at the moment this isn't ready for "prime time".
Related to this, a callback that modifies a non-dict/non-list node modifies the input. ```python import asdf class Foo: pass tree = {'f': Foo()} assert not hasattr(tree['f'], 'bar') def callback(obj): if...
Runs of romancal and jwst regtestsshow no`AsdfDeprecationWarnings` indicating so neither of these packages serialize a`named_tuple`. Romancal regtest show no `AsdfDeprecationWarning` messages with this PR: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/753/pipeline/247 JWST regtests show 2 unreleated...