brainglobe-segmentation icon indicating copy to clipboard operation
brainglobe-segmentation copied to clipboard

[Feature] Use a logger instead of print statements

Open dstansby opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. In https://github.com/brainglobe/brainreg-segment/pull/74 I noticed that several print statements are used throughout the code as a form of logging.

Describe the solution you'd like These messages to be piped through a proper logger (maybe napari has something built in that can be used?) so it's easy for users to configure whether the messages are turned on/off and where to output them to (e.g. a file or the terminal)

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

dstansby avatar Apr 21 '23 11:04 dstansby

I think these should be turned off, and everything should be either pop-ups or info in the napari help bar. Thoughts?

adamltyson avatar Apr 21 '23 12:04 adamltyson

👍 definitely happy to turn them off if they're not very useful for users

dstansby avatar Apr 21 '23 12:04 dstansby

They're useful, they just shouldn't be in the console (especially for the bundled app).

adamltyson avatar Apr 21 '23 12:04 adamltyson