Brad Rydzewski
Brad Rydzewski
> While passing the issue upstream is the easy thing to do, I don't think it's the right thing This assumes there is something we can do in this codebase...
@blopker you can use this plugin with the host machine docker socket but there are security implications in doing so (example: malicious user overwrites an image in the host cache)....
> I just tested something locally that seems to work. How feasible would it be to use host networking for the dind container, e.g. --network host from the command line?...
I'm not necessarily opposed to supporting more docker features, however, new feature requests should ideally include a target use case. Why do we need this feature? What does it enable...
Thanks for the reply. We frequently see people that just want this: ```sh # build image docker build -t foo . # run tests docker run foo # push image...
auto_tag is meant to be opinionated and simple. Either you use it as-is or you do not use it at all. There are too many ways to customize tags and...
> clarify why the current implementation behaves like this? no reason. I probably did not consider this implications of this edge case when I wrote the code. > IMHO it...
> Why DroneCI doesn't use a cache by default ? For security reasons. If we used the host machine cache, someone could send a malicious pull request that overwrites commonly...
> cache_from [...] should maybe be turned into a list if it already isn't Just confirming that `cache_from` is already a list [1] [1] https://github.com/drone-plugins/drone-docker/blob/master/docker.go#L50
yep, this would change at the plugin escalation level :)