Bradley Kemp

Results 29 comments of Bradley Kemp

Hey @mimi89999 have you tried [phish.report](https://phish.report) for this? Most phishing lists (at least any good ones) require an API key to submit to. As an open source tool, I can't...

Out of interest, why is an API so important to you? It's something on the roadmap for phish.report but more for integrating with other tools. Did you want to do...

Hey πŸ‘‹πŸ» Unfortunately, this sounds a pretty tricky feature to implement in this library. Whereas jest has you specify your snapshots in code, cupaloy does the snapshotting for you and...

Hey @mattharrigan do you have an example of a test where you're seeing this inconsistency? By double spaces are you meaning between the snapshots of variables or actually within the...

Ah are you using protobuf by any chance? The default protobuf `String()` method intentionally introduces randomness: https://github.com/golang/protobuf/issues/1269 Cupaloy shouldn't really be using the String() method by default but it'd be...

Ah awesome there already is an option for disabling `String()` methods!

Blah blah blah should review this PR

Sounds like the JSON got corrupted somehow. Are you able to share a file that fails with this error? If not, how are you saving the file to be replayed?...

Ah I see the problem: ``` "message":{"1":"{"ServerPublishingPort":56100,"BroadcastType":1,"CommandType":"RegisterCommand"}"} ``` This isn't valid JSON because the quotes aren't being escaped inside the string. It should be more like: ``` "message":{"1":"{\"ServerPublishingPort\":56100,\"BroadcastType\":1,\"CommandType\":\"RegisterCommand\"}"} ``` Really...

Hey πŸ‘‹πŸ» Would you mind expanding a bit on what you're looking to get out of this? (i.e. what benefit does printing the response give you?) Just want to make...