Brad Eck

Bound checking on string operations

2

Discussion on #133 suggested that string operations with `sprintf`, `strcat` and `strcpy`should instead use `snprintf` and `strncat` and `strncpy`. Using the 'n' functions protects against [buffer overflow attacks](http://www.cse.scu.edu/~tschwarz/coen152_05/Lectures/BufferOverflow.html) by checking...

As discussed briefly this week, here is one way of doing unit tests via cmake.

Calling `read.inp()` on an inp file that does not have [END] at the end fails with the rather cryptic error: ``` Error in rg[1]:rg[2] : NA/NaN argument ``` The error...

So far the package reads text files in EPANET's .inp and .rpt formats. EPANET can also create a binary file of simulation results. Would parsing this be useful?

testing framework

2

it's great to see some unit tests coming into the project! As there are not too many tests yet, I was curious how much thought had been given to the...

gcc14

2

cran checks are seeing a warning with gcc14 ``` Found the following significant warnings: input2.c:867:62: warning: ' section:' directive output may be truncated writing 9 bytes into a region of...