Brad Fitzpatrick

Results 90 issues of Brad Fitzpatrick

**Summary:** let us add some safety checks inside our control plane that people don't accidentally introduce network operations while holding locks or inside database transactions **Upstream status:** seems unlikely to...

tsgo

**Summary:** let us build tailscale/go's cmd/go as a static binary so it runs on NixOS, but then still be able to build cgo binaries with it. **Upstream status:** should but...

tsgo
need-upstream

**Summary:** add the `.github/workflows` directory for Tailscale **Upstream status:** not applicable. Forever forked. **Example prior commit:** 4865b8103d1fdbd1ce73b0a09b65f7dd94e663df When cherry-picking that commit, be sure to add additional tailscale.go1.NN branches to build.yml...

tsgo

**Summary:** stamp the `tailscale/go` git commit into the toolchain **Upstream status:** not applicable, probably. Haven't asked. **Importance:** important for Tailscale to debug how binaries were built **Example prior commit:** 26292c0a2e9823c4216e8776912a43fd9e50d444...

tsgo

**Summary:** add env knob to net package panic if test code does a listen on the unspecified address **Upstream status:** upstream not interested. **Importance:** not important. We could drop this...

tsgo

I got an automated PR telling us to update from pgconn 1.10.0 to 1.10.1 which gave us a helpful diff link: https://github.com/jackc/pgconn/compare/v1.10.0...v1.10.1 But it looks like the locking on `onCancelWasCalled`...

https://go.dev/play/p/2yGiVAG8PtP ```go func TestCreateTableStringPanic(t *testing.T) { p := sql.NewParser(strings.NewReader(`CREATE TABLE Foo ( SomeID INTEGER NOT NULL PRIMARY KEY, Created INTEGER NOT NULL DEFAULT 0, ExplicitExpiry INTEGER, EffectiveExpiry GENERATED ALWAYS AS...

sqlite lets you create a table `main.Foo` https://www.sqlite.org/lang_attach.html says: > The schema-names 'main' and 'temp' refer to the main database and the database used for temporary tables. The main and...

User wishes to exclude an interface from being used for disco + endpoint advertisement: https://forum.tailscale.com/t/limit-the-network-interfaces-that-are-sent-as-endpoints-for-a-device/88/4 Perhaps we could add `TS_AVOID_PREFIX=10.5.4.0/24`, which people could add to their /etc/default/tailscale. And then we...

L1 Very few
P2 Aggravating
T0 New feature
vpn-interop

Tailscale usually defaults to port 41641, which people generally like for documentation and ease-of-recognition reasons. But sometimes dinky NAT devices get overwhelmed when even as many as small handful of...

enhancement
connectivity
L4 Most users
P2 Aggravating
T3 Performance/Debugging