Bradford C. Smith

Results 135 comments of Bradford C. Smith

AFAIK, no action has ever been taken on this.

I don't currently see us having time to implement this, but I think I could find time to review a pull request, if someone wanted to create one.

I cannot tell from the example `a.js` file in the description whether the `á` character is correctly encoded as UTF-8 in the file you're actually using when you see this...

Actually, could you just attach 2 files to this issue? 1. The actual `a.js` file. 2. The exact output from closure-compiler itself. (i.e. the input that python is seeing)

What I want to know is this: Is closure-compiler actually generating an invalid character sequence to `stderr`, or is something else going on? One thing that could be happening is...

Thank you for supplying the `a.js` file. 1. I downloaded it 2. I checked out and built the latest version of closure-compiler as a Java jar file. 3. I stored...

Thanks for pointing this out. We're unlikely to do anything about it immediately, but I expect we will fix it before doing another release.

I'm not sure what you mean when you say "ergonomic integration". Can you elaborate? Maybe a code sample showing what you think should work but doesn't with my proposed solution?...

Perhaps I'm exhibiting the X-Y problem in my initial request on this issue. I'll try to state more clearly my specific concerns. I want to avoid this possible situation: 1....

I think you'd modify the code approximately here. https://github.com/google/closure-compiler/blob/15c5a2dd3e55c2bc4ed4e1eb63e537c90f0bce7c/src/com/google/javascript/jscomp/CodeGenerator.java#L421