Bradford C. Smith comments

Results 82 comments of


Bradford C. Smith

Allow google closure self-managed js dynamic imports

@MorganDream The section of code you referenced is part of the `closure-webpack-plugin` repository rather than the `closure-compiler` one. Which one of these repositories would your PR affect? I think submitting...

Reviewers for Stage 3

LGTM for Stage 3 modulo concerns from @ljharb Thanks for pointing those out BTW.

Reviewers for Stage 3

lgtm for stage 3

Dynamic ToPrimitive handling of Tuple exotic objects differs from Records

I'd like to put this in terms of what would be observably different for users. # Current behavior today for, say, a string. ``` const stringPrimitive = 'string value'; const...

#3840 - allow user to pass any path separator as --chunk_output_path_prefix

This looks good. I'm importing it and sending it through internal review and submission.

"new EventTarget()" or "extends EventTarget" throw errors

Created Google internal bug b/119637644

Support `Array.prototype.at()`

Closed by 03e06763bdfb72efee8154f95ae315be0e1cdfa2

SourceMapConsumerV3 feature request: allow disabling of approximated mappings

I believe the "approximate mappings" mentioned here represent the two places in the method where `getPreviousMapping()` gets called. https://github.com/google/closure-compiler/blob/master/src/com/google/debugging/sourcemap/SourceMapConsumerV3.java#L163 As an experiment I modified these 2 places to return `null`...

SourceMapConsumerV3 feature request: allow disabling of approximated mappings

FYI, since the data structure we're talking about is defined using protocol buffers, here's a link to documentation on using those in Java. https://developers.google.com/protocol-buffers/docs/javatutorial > 1. It sounds like you...

Regression; loss of some names in --debug output

This issue is a duplicate of internal issue http://b/179420668 Unfortunately because of the way GitHub issues get pulled into our internal system we cannot actually link them together the way...