brad112358
brad112358
@olliw42 Yes, the diversity code is still not clear to me so I may well have gotten details wrong. And, unfortunately, I don't have diversity hardware to test with. I...
I just took another look at the code. I think I got things in the correct place for diversity, but I noticed something else I missed. I'll try to re-test...
Which file are you referring to lines 380-381 in? When does cmd frames get sent? Only when configuring Rx? Yes, I agree we need to consider a future retransmission implementation...
> I wonder if it's a good idea to put all mftp replies under txbuf control, instead of only those of the read/readburst stream. Putting also the mftp replies for...
I've made several improvements in the latest commit and I think I've addressed all the comments. This is working even better in my tests.
> @brad112358 thanks! needs a rebase and squash. If you don't know how to do a git squash then ask on the code_review channel and I can do it Thanks....
@IamPete1 and @peterbarker If you could respond to my comments on your suggested changes, then I can clean this up. Thanks!
> Any chance of that tlog? As I say even with this I didn't get good results (although still better than without), have you been testing with Mission planner or...
The nominal down link data rates for mLRS are 1558, 2542, 4100, and 9102 bytes/sec. Up link is slightly slower to allow separate RC data. Data is sent in 82...
To restate my goal, this PR is just providing radios with a way to make flow control work for FTP. I think anything more is impractical given the limits of...