Paul Brabban

Results 24 comments of Paul Brabban

Hey there @bizm sorry I didn't see your issue. I'll give you a shout when I've had a proper look.

Sorry you've hit this problem - my first thought is that we could copy the `spec-or-ref` function out to another namespace and deprecate the existing one. They just generate particular...

Yeah I can see how that would be confusing... not sure exactly what to do as changing the default behaviour would break existing code

Hey, great idea! After over a year with CloudFormation I've managed to never find that document. :man_facepalming: If you're having a go and want any help let me know.

Hey, sorry I just saw this! Great work. Let me have a think about how to deal with the issues you found

I can see what you mean. If breaking changes are needed to get full and correct coverage then so be it, we'll just try and minimise the impact, maybe call...

Local run for info: ``` $ ./run_test.sh athena Setting up virtual environment Changing working directory: integration_tests Starting integration tests 15:59:49 Running with dbt=1.4.6 15:59:50 Installing ../ 15:59:50 Installed from 15:59:50...

Re: https://github.com/dbt-labs/dbt-external-tables/pull/133#discussion_r811471521 (need for `quote_comment:` key to get around invalid comment chars: this fix doesn't seem to work, at least in Athena engine v3. The whole query gets commented out...

Note - https://github.com/dbt-athena/dbt-athena/pull/161 effectively added a large subset of external tables functionality in dbt-athena itself. Might be worth trying to refactor that and utilise it to cut down on the...

@aidan-o-boyle-kroo hi there! I've just pulled this, it is still working on dbt-athena-community 1.4.6 and works against latest 1.6.1 too. ```shell $ ATHENA_TEST_DBNAME=AwsDataCatalog AWS_REGION=eu-west-2 ATHENA_TEST_BUCKET=my-redacted_bucket ATHENA_TEST_WORKGROUP=primary ./run_test.sh athena Setting up...