Arduino-PID-Library icon indicating copy to clipboard operation
Arduino-PID-Library copied to clipboard

Bug: ITerm not initialized in constructor

Open ianmccul opened this issue 11 years ago • 2 comments

The ITerm variable is never initialized. It should be set to zero in the constructor PID::PID()

ianmccul avatar Aug 26 '14 15:08 ianmccul

I suppose this would be the rigorous thing to do. In practice, ITerm is never accessed until Initialize() is called, but that could change in the future.

On Tue, Aug 26, 2014 at 11:28 AM, ianmccul [email protected] wrote:

The ITerm variable is never initialized. It should be set to zero in the constructor PID::PID()

— Reply to this email directly or view it on GitHub https://github.com/br3ttb/Arduino-PID-Library/issues/19.

Brett

br3ttb avatar Aug 26 '14 15:08 br3ttb

True. Actually I'd forgotten to call Initialize(), in my case it doesn't really do anything except initialize ITerm, and to get that initialized I'd need to initialize the Output myself, but there is not really any sensible value I can give it before I start the PID (aside from zero, just to get ITerm initialized to the same value).

ianmccul avatar Aug 27 '14 04:08 ianmccul