Breno Faria

Results 67 comments of Breno Faria

@mingshl sorry for taking so long to answer! The use-case **for now** is to use a local, asymmetric model such as https://huggingface.co/intfloat/multilingual-e5-small. This PR here is the last puzzle piece...

@navneet1v you mean making sure this works there as well? Sure, I can commit to that. I'd propose then to merge this PR now and then start the work to...

This PR has a very small surface. It doesn't change any APIs. So I believe this is not something to worry about, actually. Once the MLInferece processor supports asymmetric models...

@ylwu-amzn as I said in the comment above, there is no API change in this PR. You would use the neural-search plugin in the same way it is used today....

@ylwu-amzn could you drive the review process forward then?

I have no news. We've moved to prefixing the strings outside of OpenSearch.

@zane-neo great to hear this! I have merged your PR. Is there anything else I need to do?

@zane-neo I rebased the changes and adapted new tests that were affected by my changes. I think this is now good to go.

@model-collapse, it were busy days, I didn’t have time to go through your reply yet. Please don’t close the issue, I’ll get to it soon.