Breno Faria

The class inherits `Hashable` https://github.com/outlines-dev/outlines/blob/4f8433d8d6633b0780c3a6c27981f9adffbe49f5/outlines/models/tokenizer.py#L7 But yeah, a test would be good. Is there somewhere a documentation for contributors that could help me setup the dev env?

I've changed the PR to explicitly set the cache key computation using the `key_function` parameter of the `@cache()` decorator. This is in line with the discussion in #876. @brandonwillard what...

@brandonwillard I have added unit tests for the `cache` decorator when used in conjunction with the `key_function`. Let me know if this is sufficient for you.

> We need to confirm that this choice of key will work between sessions and across different tokenizer types (at the very least the transformer types). Since you're using all...

@brandonwillard great work on #911. If I read it correctly, there is no longer a `key_function` argument in the `cache` decorator, right? So the tests here don't make sense if...

@brandonwillard yes, I believe this might fix #853 too.

@ekagra-ranjan, nice. Would an alternative be to devise a function that will compute a unique hash given the current class members? This would not require changing the API.

@navneet1v I have been loosely following the discussions in the mentioned RFC. It's a large change that I don't expect to be stable soon – the PR is very much...

@navneet1v I have added a comment earlier today to the RFC (cf. https://github.com/opensearch-project/ml-commons/issues/2173#issuecomment-2078796787). Sure, let's open the discussion and get some PMs into it. I really don't mind leaving this...

@mingshl @ylwu-amzn, I'd really like to have this feature in 2.14. Do you think this use-case will be fully supported with https://github.com/opensearch-project/ml-commons/issues/2173? Cf. https://github.com/opensearch-project/ml-commons/issues/2173#issuecomment-2078796787 If not, I'd be happy to...