Ben Plotnick

Results 16 comments of Ben Plotnick

@macisamuele Yeah I am not too happy with this either because the errors could probably be caused by other issues. However, I'm not entirely sure what the alternative is. Could...

@macisamuele #321 fixed this, right?

@macisamuele No worries. I'll leave this issue open for the connection timeout addition. Thanks!

@bdowling I don't think the spec object is pickleable. A common pattern is to do one or both of the following: 1) memoize creating the client with something like [lru_cache](https://docs.python.org/3/library/functools.html#functools.lru_cache)...

Could you describe a bit more what you're trying to achieve? I don't think that this exists currently, but i'd be interested in hearing what you had in mind.

`no_dump` is `False` by default, which means dump, which is the current default... I can see the confusion now 😄 . I can change it to be a positive like...

@pydanny I renamed it to `dump_replay_data` (and flipped the default) so it's clearer that it isn't a breaking change by default.

I had forgotten about this PR. I fixed a flake8 issue, and I think it's ready to go now. What do you think @pydanny

@pydanny any chance you can have a look at this?