Benjamin Parzella

Results 10 issues of Benjamin Parzella

As the code and the unit-tests are developed in the same scope, this has potential for breaking the communication without noticing it. There should be some integration or e2e tests,...

epic

Support the SECS-I serial protocol for communication.

epic

The whole protocol layers are based on HSMS. These must be refactored/redesigned to allow more communication interfaces (SECS-I).

epic

When this was created I used a lot of C#, which imho manifested itself in the code. Update the code to remove such constructs if there are mode pythonic ways...

epic

There are a few classes that are quite big. Check how they can be split and simplified (mixins, ...)

There are quite some code smells: https://codeclimate.com/github/bparzella/secsgem/issues - [ ] #50 - [ ] #51

epic

There are a few functions that are quite complex (see code smells)

Virus scanners scanning port 5000 might interfere with handler. Eventually leaving it in an unknown state.

bug
question