Bowen Liang

Results 170 comments of Bowen Liang

Thanks for the validation and merging. @iamjoel Btw, would you like to have `pm2` for monitoring Python service in api docker image as well? @takatost Here's some possible reasons and...

I'm wondering how we miss this case of updating iceberg table, as we do have update iceberg table in unit test (IcebergCatalogRangerSparkExtensionSuite). Can you provide more information about the issue...

It seems Iceberg implements update command as `ReplaceData` in 0.12 and below, and `UpdateIcebergTable` in 0.13 and above. That's the main reason for missing this case in unit tests as...

Btw, you'd better update `org.apache.kyuubi.plugin.spark.authz.gen.TableCommands` and regenerate `table_command_spec.json` by running `JsonSpecFileGenerator`.

https://github.com/apache/kyuubi/pull/4493 is already merged to master. You could merge master to your PR branch or rebase your changes to master.

Noticed the magic values for plan name matching are coming back in the current implementation. Consider adapting the implementation to the new Serde design pattern in Authz, especially in PR...

As the `org.apache.kyuubi.plugin.spark.authz.v2Commands` and `IcebergCommands`, they are implemented and attempt to adapt a general pattern to intercept logical plan. So far, I think the Arctic could follow the same pattern...