kyuubi
kyuubi copied to clipboard
Fix arctic command ReplaceArcticData
Why are the changes needed?
In arctic command ReplaceArcticData, Identifier is of type Option and cannot be obtained in the original way
How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[ ] Add screenshots for manual tests if appropriate
-
[x] Run test locally before make a pull request
Codecov Report
Merging #3561 (8788c3b) into master (8788c3b) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 8788c3b differs from pull request most recent head 956b43d. Consider uploading reports for the commit 956b43d to get more accurate results
@@ Coverage Diff @@
## master #3561 +/- ##
=========================================
Coverage 52.93% 52.93%
Complexity 13 13
=========================================
Files 497 497
Lines 27994 27994
Branches 3860 3860
=========================================
Hits 14819 14819
Misses 11780 11780
Partials 1395 1395
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Can you provide a test case ?
cc @bowenliang123 Any idea about how to better integrate with other spark catalog extensions ?
As the org.apache.kyuubi.plugin.spark.authz.v2Commands
and IcebergCommands
, they are implemented and attempt to adapt a general pattern to intercept logical plan. So far, I think the Arctic could follow the same pattern as IcebergCommands to do it. For further plan, if the pattern is generalized well enough, it's ok to provide a pluggable implementation through SPI mechanism to use custom auth mapping plugin. @zhouyifan279