Joey Reid

Results 29 comments of Joey Reid

I appreciate this detailed response! There's no mention of any of these things in the relevant closed issues, which is why I opened this issue. Can you share links to...

I would like better messages, but I think the best way of doing that would be to check that the inputs received by the function are the correct type (as...

I'm running into this as well. The documentation doesn't say anything about which components of theme are respected in `guide_legend`, at the moment there's no warning or error, the plot...

I've been working with the csv output of `travel_time_matrix` for a large region and many of the csv files contain only a few lines, performance reading 30k files is poor....

Duplicate of #318 layer_paths also fails: ``` r mtcars_dt %>% ggvis(~wt, ~mpg, stroke = ~as.character(gear)) %>% layer_points() %>% layer_paths() ``` The problem is specifically in the grouping or property. So...

I'm pretty sure enums are enumerated by value in the spec, e.g., https://github.com/TIDES-transit/TIDES/blob/b4d722cff27b0c35a12b27703ebd3a6732df66ef/spec/vehicle_locations.schema.json#L170 and https://tides-transit.org/main/tables/#vehicle-locations. Are you asking for option 1 (adding `"enumOrdered": true`), or 2, using integers for the...

> This could be dealt with a few ways: > > 1. TIDES could be explicitly serialization format agnostic. This is the current state, and seems desirable as it leaves...

High-level, I'm not sure about the utility of generating random data to validate. It's a bit circular, and I'm not sure there's any real benefit. For example, could the random...

spaces in urls! here's a link that works But what's really annoying about that link is that it's just a way for them to monitor usage? The artifact is in...

@e-lo, can you resolve or address the comments I left in my last review?