Emanuele Bosoni

Results 40 comments of Emanuele Bosoni

Sorry for the late replay. The commands to run are: - `aiida-pseudo install pseudo-dojo -v 1.0 -f jthxml` - `aiida-pseudo install sssp -p efficiency` - `aiida-pseudo install sssp -p precision`...

@sphuber I would like especially a feedback on how to handle defaults of the `second_relax_inputs`. I thought that using `populate_defaults = False` was enough for the exposed inputs to forget...

I will also now write few tests

> If you make a subprocess completely optional and rely on determining whether it should be run based on whether any inputs were defined, you don't want the defaults to...

Ok, thanks @sphuber, I understand, but then this does not cover my use case, since I want one input in the namespace to be populated, and the others no. How...

I addressed almost all your comments @sphuber. Two are open for discussion. Thanks for your review. However I found another problematic behavior of the ports. It seems to me that...

The issue I found is here https://github.com/aiidateam/aiida-core/issues/5286

@mbercx thanks for the implementation. It looks great. The only discussion we need to have is regarding the additional input `clean_workdir` you introduced for the `QuantumEspressoCommonRelaxInputGenerator`. I think that I...

@mbercx you are actually right. Not bad to make `clean_wordir` an input for everybody. I will suggest it today. But I will be in favour to make it False as...

@sphuber @giovannipizzi The implementation should be now concluded, with the caveats below: 1) The issue https://github.com/aiidateam/aiida-core/issues/5342 explains the difficulty I had in implementing our idea to serialize the content of...