bosd comments

Results 689 comments of


                                            bosd

[16.0][FIX] base_substate: track template on substate

@pedrobaeza Is this one ok for you now?

[16.0][MIG] base_tier_validation_correction

@ChrisOForgeFlow Can you attend to this? 🙏

[16.0][MIG] base_tier_validation_correction

@ForgeFlow Can you attend to my comments?

[16.0][MIG] base_tier_validation_correction

Yes @AlexPForgeFlow Let's go!

Added logic to extend base_tier_validation module with hr department

@gcaceres93 Can you fix tests and pre-commit? Please make comments in the code in English.

[17.0][RFC] base_tier_validation: remove unused code

the function `get_reviews` was no longer called upon in the javascript. After this commit. https://github.com/OCA/server-ux/commit/145c5702fc51eaf6622ed38d64ce0dd26b7dc145#diff-5d679fcb388f892b31b8c390404d207ed9b96c806e57db499e13d04443d628e9L33 (or anywhere else afaik) But it still was unit tested. The remaining code might need...

[17.0][RFC] base_tier_validation: remove unused code

@LoisRForgeFlow Done, I removed those fixes.

[17.0][RFC] base_tier_validation: remove unused code

@LoisRForgeFlow With the earlier mentiond fixes removed tests are indeed failling. (Some time has passed since I started working on this. While quickly looking at this, I don't know why...

[17.0][RFC] base_tier_validation: remove unused code

@LoisRForgeFlow Yes it is.

[17.0][RFC] base_tier_validation: remove unused code

@LoisRForgeFlow Ive included the fixes again. Is it ok to merge it as is? As I don't expect to have some time available in the near future to dig very...