Boris Farber

Results 48 comments of Boris Farber

Thanks Liz, Few thoughts on my end 1. Please accept the contributor CLA 2. Can we have a doc (could be an .md file) descriping this functionality, as other developers...

More thoughts: 1. I will re-check the CLA 2. Please fix the following tests > Task :aspoet:test com.google.androidstudiopoet.generators.ModuleBuildBazelGeneratorTest > generator applies dependencies from the blueprint FAILED org.mockito.exceptions.verification.junit.ArgumentsAreDifferent at ModuleBuildBazelGeneratorTest.kt:46 com.google.androidstudiopoet.generators.android_modules.AndroidModuleBuildBazelGeneratorTest...

@lizyxr - thanks a lot @NikitaKozlov - please review Added some comments =========================================== What would be our thoughts on: 1. Havig a seprate md file for these feature + sample...

Ok, once the review comments are fixed, I will merge the change. In addition will open a bug(features request) for jar generation.

I don't know yet... Lets finish the stuff you are working on; and add code complexity inside. Once we have it we will re-eval our approach.

Suggestion, we use the attached files as seeds download them [programmatically](https://github.com/android/android-studio-poet/blob/master/aspoet/src/main/kotlin/com/google/androidstudiopoet/writers/GithubDownloader.kt) and change to appropriate class & constructor names: [CSVLexer.java.txt](https://github.com/android/android-studio-poet/files/2331139/CSVLexer.java.txt) [CSVListener.java.txt](https://github.com/android/android-studio-poet/files/2331141/CSVListener.java.txt) [CSVParser.java.txt](https://github.com/android/android-studio-poet/files/2331142/CSVParser.java.txt) Once we happy with the Java code we...