Bony Roopchandani

Results 13 comments of Bony Roopchandani

@nadenf good point. `TemplateContextProvider` is something which is always required so yeah adding to README will be a good idea.

@raaaahman 👋 Thanks for the PR. I have changed the main branch to develop to test out the changes but looks like there are some conflicts. Can you please resolve...

Ah I see. I believe we can get this PR ready to only work with React 18. Let’s make this compatible with latest React version.

Closing this as the package was recently updated to support react 18

This looks like a great feature. I think we can modify the caller function to include extra terminal-related arguments which can include a bunch of data including the command.

> Support on a theme level could be useful. I would imagine something would need to be edited around here in addition to the theme objects, but I'm not really...

This can be a quick fix, but more future proof approach would be to go with the extra data passed on to the callback function.

@asnewman That's a great idea. The terminal component current works on the concept of single input to single output and doesn't support these flows as you mentioned, so a PR...

@masoodhesami Did you wrapped your main app entrypoint with `TerminalContextProvider`? More details in [README](https://github.com/bony2023/react-terminal#usage)

@masoodhesami Can you share the snippet on how you are initializing the terminal?