Mauko Quiroga-Alvarado

Results 205 comments of Mauko Quiroga-Alvarado

Just to complement my previous comment: 1. We can remove the service Coveralls 2. I'll propose a PR to fix the coverage issue —thanks for reporting it!

Thanks to this issue, I discovered that doctests are not being run 🤯

I'm not sure if this is a new feature, or a bug-fix as the behaviour this adds was introduced as a replacement of a behaviour that was deprecated, however the...

> @maukoquiroga : looks very good to me. Just a question: how does this PR handles month day size, february and leeap year for divide_by_period ? It does not seem...

(By the way, I think that holders implements it's own logic in terms of equivalences between days, months and years. We should see which is better, and keep just one...

I've tried to distill what could be a short-mid term roadmap for OpenFisca-Core here: * https://github.com/openfisca/openfisca-core/milestone/2 * https://github.com/openfisca/openfisca-core/milestone/3 * https://github.com/openfisca/openfisca-core/milestone/4 * https://github.com/openfisca/openfisca-core/milestone/5 * https://github.com/openfisca/openfisca-core/milestone/6 @MattiSG I see that you've been...

@MattiSG At least for #1061 , #1062 , and #1063 , if there's no preliminary waver needed from the community, I just had in mind to ask for contributions —but...

@MattiSG Exactly, that could have been accepted ...

Hi @benoit-cty and thanks for this issue. I see there is an option overlap regarding `-n` https://github.com/openfisca/openfisca-core/blob/master/openfisca_core/scripts/openfisca_command.py#L34-L43. So I've tried this: `PYTEST_ADDOPTS="--numprocesses=auto" openfisca test --country-package openfisca_france tests` And got: `...