David Bock comments

Results 22 comments of


                                            David Bock

Trouble understanding results

this is different than #116 and seems like a real bug. both of your test cases should result in the Thursday date. will investigate.

Short days before holiday

Out of all the requirments people ask for regarding this gem, this would be the most useful. I have no plans to implement it, but you's accept a pull request...

business_time_until doesn't account for holidays when called on Time objects

Will investigate.

business_day.after does not handle starting time outside business hours properly

This is correct behavior. Here's what happens: 1) Saturday, August 17th at 12:54 am is not a business day. 2) We roll forward. the next business day starts Monday morning...

business_day.after does not handle starting time outside business hours properly

Hmm... I agree, this seems like a real issue.

handling negative business hours & days

Not a bad suggestion, but not one I have the time or inclination to research. I'll gladly accept a pull request with appropriate tests though.

Business days calculation broken in 0.7.5

this was an accident. I'm looking into it now. Accepting multiple pull requests, dealing with monkeypatches on top of ActiveSupport Monkeypatches becomes a lot to deal with. Future versions will...

Business days calculation broken in 0.7.5

I am not seeing the issue you describe above. Here I am with your test cases: ``` ruby Time.now 2016-06-09 10:37:42 -0400 2.business_days.ago 2016-06-07 10:37:58 -0400 2.business_days.ago.in_time_zone("America/Los_Angeles") Tue, 07 Jun...

inconsistent business day calculation between sunday afternoon and monday AM

this seems to be related to #149 I'll get a test case and investigate

Is the shoot out data available?

I’m referring to the candy voting dataset indicating which two candies went head to head and which one the person picked. According to the article you also collected IP addresses...