bojanserafimov
bojanserafimov
Alternatively, we can disallow inequality filters with uuids that are not db-agnostic (see https://github.com/kensho-technologies/graphql-compiler/pull/765/files). This makes our backends behave the same, but limits the expressive power of the filter.
Worth checking why `test_query_pagination.py:test_with_compiler_tests` doesn't catch those bugs. It runs pagination against all defined compiler test inputs, checking that no errors are raised.
Ah, the current tests pass because we always paginate at the root right now. We have tests for the parameterizer that make it insert filters on a different path, but...
My proposal is to deduplicate the result in all backends, and (eventually) add a compiler flag called "skip_recurse_deduplication" to be used when the user does not want to pay the...
@pmantica1 yes, you can sort without outputting https://www.db-fiddle.com/f/2JEznqXyqj6VKSnLh5dmV2/0
Good point with `ascending: Bool!`. I don't really have a preference, but I think your suggestion makes sense.
> Do `enum` types work in directives? Sort order feels like an enum more than like a boolean. I'll try it out. I was assuming no, because we don't use...
Enum values work. I parsed a query using an enum value in a directive and then validated it against a schema.
> Off-topic, but should we be thinking about switching to enums for filter operators as well? I'm not sure `=` and ones like it are allowed enum values, but maybe...
Let's use enums then: ``` enum Order { ASCENDING, DESCENDING, } ``` Does the rest of the design sense? Thumbs up this comment if it looks good, so we can...