boholder

Results 113 comments of boholder

I decide to create yet another PR just for doc, I'll do it now. @TheSuperGamer20578 This PR can't be assigned to you for reviewing so... take a look at the...

There are two dependency questions and one code opinion waiting for @TheSuperGamer20578 to answer... see the comments in "17 hidden items"

As far as in 1.19.3, the logic of `ItemEntity.onPlayerCollision` is: ```java public void onPlayerCollision(PlayerEntity player) { if (!this.world.isClient) { // this always = 0 Air ItemStack itemStack = this.getStack(); Item...

~~Once #347 is merged, this issue will be closed.~~

The precondition of assertions below is the final result works like what I described in this issue: > Does this mod handle 3D panning so you would know if something...

It worth note that, the [NamedFormatter](https://github.com/minecraft-access/minecraft-access/blob/dev/common/src/main/java/org/mcaccess/minecraftaccess/utils/NamedFormatter.java) I made, to format strings like `{foo} at {bar}`, this type of string will be marked by IntelliJ MC dev plugin, says its format...

> I don't see any warnings in mine, where does it show you that warning? See in IDE https://github.com/minecraft-access/minecraft-access/blob/ac9a286c752aa164bdbd03e1474ff611023f5d21/common/src/main/java/org/mcaccess/minecraftaccess/utils/NarrationUtils.java#L121 https://github.com/minecraft-access/minecraft-access/blob/ac9a286c752aa164bdbd03e1474ff611023f5d21/common/src/main/java/org/mcaccess/minecraftaccess/utils/NarrationUtils.java#L68

> I'm not getting that warning for some reason, though looking at it I would expect to see a warning there. I suspect the warning is just the plugin not...

> Of course this is tentative and subject to change, I think `Key` might conflict with some other classes which would make it annoying to use so it is likely...

I finished browsing all reports, you can take a look at comments I left in config file