Bogdan Drutu comments

Results 550 comments of


                                            Bogdan Drutu

Validate TLS config: return error if cert or key is missing

Please add changelog entry

Avoid the exporter for being stuck when telemetry data is bigger than batch.max_size

@iblancasa I will do all the comments I asked you and did not do... In the followup

Remove deprecaterd consumererrorprofiles module

Needs a rebase.

Clearly separate Config and Settings terms used in struct names throughout the codebase

I think we should start working on this, because we cannot delay until the stability.

Define attributes for internal metrics in metadata.yaml

This is good, but less than ideal. See https://github.com/open-telemetry/opentelemetry-collector/pull/11365 The best performant way is to actually construct the full `MeasurementOption` (result of `metric.WithAttributeSet(attribute.NewSet(attribute.String("exporter", exporter)))`) otherwise if I am not mistaken...

[exporter] moved mergeBatchFunc and mergeBatchSplitFunc to request

Please rebase

[chore] Capitalize feature gate UsePullingBasedExporterQueueBatcher

Please explain the motivation.

SNOW-1763555: OpenTelemetry integration utterly breaks driver if using DataDog

> I would expect that opentelemetry integration would be done via this- https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation > > and not via a hack in the actual library that breaks the driver for anyone...

Open Telemetry internal metrics of type "counter" emitted via prometheus exporter not comply prometheus metrics naming convention

You can achieve this by configuring the `without_type_suffix = true`, see also https://github.com/open-telemetry/opentelemetry-collector/issues/12458

Remove one of the nopexporter.NewFactory or exportertest.NewNopFactory

Can I ask a different question. Is the nop exporter/processor really useful as a standalone component? Can I get some arguments why we need that?