Bogdan Drutu
Bogdan Drutu
@Mario-Hofstaetter @mx-psi first of all, thank you for this issue. I have some confusions/questions here: * I am confused about the meaning of "--dry-run", we can discuss if "-dry-run" means...
@pellared that is different because Logger is not a real logger :) (I said this many times, but I will repeat). For EventLogger which is a real Logger, users will...
> Is the expectation that filtering is done at the OpenTelemetry level based on severity? (From my experience, such filtering is typically done inside the logging framework itself, so logs...
I think that is actually a good solution.
@kruskall how can you check if DCE is disable and what causes that?
@debugmiller how can you measure that? Also what does your "binaries" include?
Based on my example in https://github.com/open-telemetry/opentelemetry-collector/pull/13373, there is improvement with the replacement, but I am not near close to 100 MB
Tried also https://github.com/open-telemetry/opentelemetry-collector/pull/13374 and improvement is very little, 300KiB...
@debugmiller > I used kruskall's suggestion to bump the version of github.com/modern-go/reflect2 which fixed my problem. FWIW I think this is actually an issue that needs to be addressed upstream...
After https://github.com/open-telemetry/opentelemetry-collector/pull/14079 and https://github.com/open-telemetry/opentelemetry-collector/pull/14078 there is only one library that disables DCE which is the use of `html/template` in the `service/internal/zpages` as well as in the `go.opentelemetry.io/contrib/zpages`. Tested (using https://github.com/aarzilli/whydeadcode)...