Bogdan Drutu
Bogdan Drutu
I think this is great.
I need to get @open-telemetry/collector-approvers consensus, since this is a breaking change without deprecation.
> Is there a way to know this outside of the repository? * Contrib passes (so that is a good sign). * Based on my knowledge only AWS may have...
Looks like we have 3 approvers, and first provider coming to contrib soon. I will merge this and update contrib so we can have that one implementing the new interface.
@dmitryax I don't feel is that significant, since we are making the "helper" funcs to look like the Factory funcs (which are the significant once. But more eyes are always...
Per the approvers from https://github.com/open-telemetry/opentelemetry-collector/pull/5834 I take that this is fine as well
> I don't think it's a breaking change though, after these changes if queue_size has been specified in the config, a warning is logged and that value is used instead...
This PR needs to be re-created after the cleanup of enabling the persistent queue.
> OpenTelemetry SDK should generally be configurable via env vars. Unfortunately this is true because the TC members were lazy (starting with the person who writes this) and have not...