Bogdan Drutu
Bogdan Drutu
You can achieve exactly the same behavior by having internally a `shared_ptr` and have the copy ctor/assignment do ref and destructor unref, and when out of scope you call End....
@lalitb can you please explain a bit more > But this will make it difficult to maintain ABI compatibility. Any changes in internal structure of this non-abstract Span can break...
@codeboten please rebase @Aneurysm9 @MrAlias please help us with this PR.
@codeboten please rebase
@codeboten you need another rebase
@MrAlias @codeboten the metrics API is stable, let's move forward with this PR :)
Then I would add that on the `Iterable keys(C carrier);` as well because that seems forgotten
Documentation and maybe change the `keys` API to also support nullable can be done after GA, I think adding the annotation is ABI compatible.
@Oberon00 can you please give details if this is still needed?
/cc @james-bebbington @nilebox @zoercai