Caleb Van Dyke
Caleb Van Dyke
I think we can change this to turn down the last started replica to fix the issue
We might be able to do https://github.com/launchflow/buildflow/issues/111 and have this help fix this issue. i.e. if one actor in the placement group dies then restart it or restart all of...
Definitely! All the file io is in this file: https://github.com/launchflow/buildflow/blob/main/buildflow/runtime/ray_io/file_io.py The enum here has the list of file types we support: https://github.com/launchflow/buildflow/blob/main/buildflow/runtime/ray_io/file_io.py#L18 And in the `_write` method defines each file...
We mostly just did that from preference. Previous it was nice to use to setup ray specifics in the setUpClass methods, but we moved that to a pytest fixture, but...
Hmm interesting probably an issue with our permission set up. Let me try and update those
Alright turns out it was an issue with when the workflow runs. I updated it in https://github.com/launchflow/buildflow/pull/138 to run on PRs. So I think if you pull down the latest...
I'm happy to take a stab at fixing this should be pretty straight forward I believe
Fix should be here: https://github.com/opentofu/opentofu/pull/1657
> @boetro looks like golangci-lint is complaining. @cube2222 sorry about that should be fixed with the latest commit
@cube2222 ok should be good this time