Erik Pragt

Results 241 comments of Erik Pragt

Well, when looking at this: https://libphonenumber.appspot.com/phonenumberparser?number=%2B61403475700 I thought it might be nice to have something like a national and international format. So yes, two lists or regexes would probably be...

Bulgarian (BG) phone numbers are fixed now.

You're probably right, but github is a bit limiting. I thought it would be fine to just put a comment here. I didn't really want to create ~30 issues just...

@panilya I'm not 100% sure. There's a script which generates this output, there might be an issue in the script. I know there was some mixup or so in the...

@panilya how about we just close the ticket? It has improved quite a bit, so to me it's good enough.

> @bodiam I wanted to do it. There are like +-4-5 locales with error code > 35. Maybe open another issue for these locales or it's better to not? I...

> @bodiam I have a question not related to this issue. You have mentioned a tool for generation `providers.md`, I work on it and have questions about implementation. How to...

Awesome! Great improvements there, thank you!

> ok, now there are 20 successful builds in a row https://github.com/datafaker-net/datafaker/actions/runs/2906808090 Awesome, thanks for your work on this. Let's hope this was the final bit.