datafaker icon indicating copy to clipboard operation
datafaker copied to clipboard

Set mapOfMethodAndCoercedArgs to non static, add description for test…

Open snuyanzin opened this issue 3 years ago • 1 comments

Make mapOfMethodAndCoercedArgs non static to avoid concurrency issues add description for tests

snuyanzin avatar Aug 04 '22 16:08 snuyanzin

Codecov Report

Merging #275 (d4a6f93) into master (2265045) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage     94.89%   94.89%           
  Complexity     1911     1911           
=========================================
  Files           200      200           
  Lines          3817     3817           
  Branches        379      379           
=========================================
  Hits           3622     3622           
  Misses           99       99           
  Partials         96       96           
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.92% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 04 '22 16:08 codecov-commenter

ok, now there are 20 successful builds in a row https://github.com/datafaker-net/datafaker/actions/runs/2906808090

snuyanzin avatar Aug 22 '22 21:08 snuyanzin

ok, now there are 20 successful builds in a row https://github.com/datafaker-net/datafaker/actions/runs/2906808090

Awesome, thanks for your work on this. Let's hope this was the final bit.

bodiam avatar Aug 22 '22 23:08 bodiam

probably this change was the most important https://github.com/datafaker-net/datafaker/pull/275/files#diff-ee97fe2f9fc8eaa7521b384156ad4c142059c3bb6f692e1698067aafc647f55bL36-R36

I didn't expect that in currency_code for uk there could be empty value and from another side a mandatory check for absence of empty currency codes...

snuyanzin avatar Aug 23 '22 07:08 snuyanzin

The heck :) that's weird indeed. You'd think by now most of the crazy parts are gone, but seems there's still some hidden gems in the code!

bodiam avatar Aug 23 '22 09:08 bodiam