Bogdan Katyński

Results 9 comments of Bogdan Katyński

no the two return different things. the first one calls ``` Logstash.get_attribute_or_default(node, @name, 'create_account') ``` which reads the value of the `node['logstash']['instance_default']['create_account']` which is set to true in `attributes/default.rb` rendering...

Ok but what's the point of letting the user set a resource property if it's getting overriden anyway and is always true? To me this is clearly a bug.

I've just spent an hour trying to figure out why ``` logstash_instance 'name' do ... create_account false end ``` is trying to create the account.

no. I do not set ``` default['logstash']['name']['create_account'] = true ``` I'm only calling the resource.

IMHO the utility method should only be called IFF the property isn't set.

well but the utility method isn't called for String properties when they're set. The problem is the use of `||` operator. It's works as expected for String/Array because strings or...

the root of the problem is that an unset boolean and a boolean set to false are both falsey. and I believe that the utility function should only be called...

Thank you for pointing me to the workaround. Since my patch may break backward compatibility, I decided to try it. I set ['logstash']['instance'][instance_name]['create_account'] to false in my recipe so now...

Hello @bryannaegele how are you getting on with this feature? I would like to help if you need a hand. I started studying the code and think that the Aggregator...