Hongbo Zhang comments

Results 243 comments of


                                            Hongbo Zhang

Feature Request: Option::or_return_none()

hi @gmlewis we will add features like this which is more general and readable: ``` guard let Some (x) = expr else { return None } guard let (Some (x),...

Need a way to disable or override `spectest.print_char` in wasm output

@peter-jerry-ye can we do it for this week's release?

Is it necessary to implement hash/compare trait and for Array?

compare is needed, not sure about hash though

Is it necessary to implement hash/compare trait and for Array?

I agree we should add hash for Array, user can always misuse HashMap if they want

Make bsb able to compile all third-party artifacts into the top-level lib/

it is okay to move .cm[ij] files into lib, but it is complex for js files

implement Map::update

FYI, the `update` in OCaml is more general: ```ocaml val update: key -> ('a option -> 'a option) -> 'a t -> 'a t (** [update key f m] returns...

"The error type of this function is never used" should be a warning rather than an Error

@zxch3n will fix it soon

Future work: Introducing a dsl for FFI instead of abusing attributes

Indeed, this looks more uniform, but it makes code analyzer more difficult. From what I can tell, it does not do any analysis or check though. ```fs open Fable.Core []...

Future work: Introducing a dsl for FFI instead of abusing attributes

yeah, it is the road map(after we finish the data representation changes). The flow parser is more tested (used more). On Wed, May 6, 2020 at 5:21 AM Javier Chávarri...

Future work: Introducing a dsl for FFI instead of abusing attributes

I am thinking we can just use the most intuitive way of writing FFIs ```ocaml external add : int -> int -> int = "function(x,y){ return x + y }...