Hongbo Zhang

Results 243 comments of Hongbo Zhang

There is a problem when you have both a.res and a.res.js, the require will pick the former which isn't what you want

> I see no problem with specifying a full path. Like require("./SomeResModule.res.js"). Or what do you mean? `require('./xx.res')` does not work while `require('./xx.res.js')` works, this would cause some surprise. Let's...

@chenglou yes. Is it a high priority

so I fixed that dry-run mode will not touch .compiler.log in #4710

@butterunderflow A proposal for fix: when `...` only appears in the tail position, nothing changes, so no regressions would happen. when multiple `...` appears ``` list{ a0 , ... b0...

> Perhaps one possibility would be to make char be an alias to int, and try to get int exhaustive matching to kick in. But is that even right? >...

sounds great, would you send a PR on this? thanks

> Also, if something works differently between browser and node, you can search for this BS_COMPILER_IN_BROWSER to see the conditional compilation applied for browser. Yes, my original hack is just...

I will have a look this weekend 发自我的iPhone ------------------ Original ------------------ From: Khoa Nguyen Date: Fri,Aug 2,2019 3:25 PM To: Sketch-sh/sketch-sh Cc: Hongbo Zhang , Mention Subject: Re: [Sketch-sh/sketch-sh] BS...