reason-react icon indicating copy to clipboard operation
reason-react copied to clipboard

Minimal example on ReasonReact website has an unused variable "name"

Open josdejong opened this issue 5 years ago • 2 comments

The ReasonReact website (https://reasonml.github.io/reason-react/) has the following minimal example on the front page:

[@react.component]
let make = (~name) =>
  <button>
    {React.string("Hello!")}
  </button>;

Here the prop name is not actually used.

Maybe it's an idea to change this to render something like {React.string("Hello" ++ name ++ "!")}?

😄

josdejong avatar Dec 19 '20 16:12 josdejong

sounds great, would you send a PR on this? thanks

bobzhang avatar Dec 22 '20 07:12 bobzhang

Okido, here you go: #640

josdejong avatar Dec 22 '20 09:12 josdejong