Bob van der Linden

Results 46 comments of Bob van der Linden

I think it should result in a permission error. Right now the method doesn't exist at all, which makes it not compatible with running Deno locally. Knowing that it will...

Shouldn't it just be giving a permission error instead of the method missing? Now developers cannot presume any of the `Deno` method to be available. Libraries should be supporting this...

This looks like a good fix for the issue I ran into (`pkexec` is not in `/usr/bin/pkexec`, but is available in `PATH`). :+1: @jorangreef could you have a look?

To get this further along, would it be possible to hook lifecycle events outside of a component? That would make it possible to create a third party library that provides...

Just to share my findings: I have tried to set `ngOnDestroy` inside the constructor, but this will not work. It seems to check whether the method is created using reflection...

Ah, just realized this PR to be here. I submitted #112 that does include the original rules with some explanation what it solves and the source of the rules.

I ran into this problem on nixpkgs. The documented command `nix-shell -p nox --run "nox-review wip"` currently shows an error: ``` Usage: nox-review [OPTIONS] COMMAND [ARGS]... Error: No such command...

Same issue here. I presumed `rawRequest` would not throw exceptions upon receiving errors, as the type signature shows it returns errors in its return type. Good to see at least...

Yes, I've thought about adding this as well. It would probably need a separate interface (`IFileSystemAsync`?) that always result in `Task`. Existing `IFileSystem` implementations can be wrapped by a `IFileSystemAsync`...