Aiden Woodruff

Results 27 comments of Aiden Woodruff

Ok, that would be good. It would be best to tell the Capstone guys how to build once and not have to change the instructions super quick after.

I think that sounds like the best method. Accept old names in CMake configuration, but convert to the new names (and use new names in CMake logic). Then old config...

I think the main thing to do is change the CMake project name: https://github.com/SCOREC/core/blob/7e8072d58e77a1a2279beb6f9fb2180fe59f11d5/CMakeLists.txt#L9 Then Dan's bob.cmake will change a good chunk of the options. But there would certainly be...

@onkarsahni Do you have any insights in terms of Capstone and periodic meshes? Is that something they might support in the future? If we remove the `#ifndef HAVE_CAPSTONE` the expensive...

We have not yet received input, but I am going to merge this for now since it suppresses the compilation warning without further judgement calls.

If we're making changes to support later C++ standards, I would like to see APF_ITERATE deprecated. If there are internal uses they should probably be range-based for loops.

I'm talking specifically about the STL iteration helpers in apf.h: https://github.com/SCOREC/core/blob/17ad033da30c8079a69e8142486ce01892c562b8/apf/apf.h#L634-L649

Nope, just a wish-list item.

Parma splitting only allows partitioning to power of two parts. We recently added partitioning with METIS that would allow arbitrary partitions, but I expect there would still be other issues.

I added a commit in my PR #487 which adds the 'Partitioning' group. The documentation could be on that group page.