core icon indicating copy to clipboard operation
core copied to clipboard

Fix unused variable warning introduced by #446

Open bobpaw opened this issue 1 year ago • 1 comments

Fix unused variable warning introduced by #446

This fixes an unused warning when CMake is given -DENABLE_CAPSTONE by casting to void.

However, I wonder if we can remove the #ifndef altogether? Currently we expect Capstone meshes to never be periodic. But if they are periodic, I would expect we might want to do the recalculation.

bobpaw avatar Sep 13 '24 14:09 bobpaw

@onkarsahni Do you have any insights in terms of Capstone and periodic meshes? Is that something they might support in the future? If we remove the #ifndef HAVE_CAPSTONE the expensive parametric call still won't be made unless it's a 2d periodic mesh.

bobpaw avatar Sep 13 '24 16:09 bobpaw

We have not yet received input, but I am going to merge this for now since it suppresses the compilation warning without further judgement calls.

bobpaw avatar Nov 04 '24 16:11 bobpaw