Bob Carpenter
Bob Carpenter
#### Summary: Expose the implementation of Pathfinder and multi-path Pathfinder through service functions. #### Description: Although they are very close, I decided that two service functions would be simpler than...
Idea from Aki Vehtari on stan-dev: In Stan 2.8, log density functions like `normal_log()` output the sum of the densities of their components (with appropriate broadcasting of scalars). It would...
Our input mechanisms for data and inits should handle NaN and +inf and -inf values. The new JSON reader handles them for input. But the current R dump format reader,...
#### Summary: The `deep_copy` function is applied to right-hand sides of assignments to avoid aliasing. However, all of our array slicing makes a copy itself, so this isn't necessary. Also,...
#### Summary: The merge trailed a bunch of todo items: ``` stan/src/stan/command/stanc_helper.hpp: // TODO(martincerny) help for standalone function compilation stan/src/stan/command/stanc_helper.hpp: // TODO(martincerny) Check that the -namespace flag is not set...
#### Summary: As pointed out by @bgoodri on stan-dev list, truncation syntax is generating ``` if (y < 1) lp_accum__.add(-std::numeric_limits::infinity()); else lp_accum__.add(-poisson_ccdf_log(1, rate)); ``` Instead it should be throwing `std::domain_error`...
#### Summary: Suggested changes 1. Move dim validation from model generated code to var_context (see example code below) 2. Optionally, move transforms into their own classes rather than triplets of...
#### Summary: It'd be nice to have a builder pattern for var contexts to make them easy to construct for testing. Something that could be used like this: ``` MatrixXd...
#### Summary: From Rob Goedman on stan-dev, there's an issue with two chains and thinning. #### Reproducible Steps: When running a mode My test model: simple.stan: ``` data {real sigma;}...
#### Summary: Two arguments to the service functions (all functions in `stan/services/...`) should be made constant: - [X] `io::var_context`: this should be easy as `var_context` has appropriate `const` declarations -...