Bob Carpenter

Results 667 comments of Bob Carpenter

I didn't see a related issue this solves, but the PR indicates it's failures for some RNG seeds. So the obvious question is why there are failures. Is it just...

Stan separates two kinds of errors. If there are indexing errors, we tend to throw things that stop the algorithm because those aren't recoverable. If they are numerical errors like...

Sounds good. This is a good example of why we don't want the doc to indicate *how* the function is implemented, but rather just precisely define *what* it does.

That's a good point and we should clarify. * The target density has parameter `theta` with density `p(theta | y)`, where `y` is data. * In HMC, we couple a...

The term "canonical distribution" is how the physicists refer to it. The other physics term that's relevant is "phase space," which refers to the coupled `(theta, rho)` variables. I don't...

I agree and that has been the plan all along. We have to keep in mind that we are going to have to set a fudge factor in the Z...

Another issue I'd like to bring up for API design is how we run multiple samplers. For example, a sampler like random walk Metropolis generates a single Markov chain of...

@WardBrian: This one's not quite ready for re-review until I get test coverage up to 100%. Is there a way to see what the coverage is? I already know that...

> I’m a bit hesitant about going all in on docstrings right now I'm in favor of getting the details into doc sooner rather than later for several reasons in...

I brought this up to date with the existing branch. All tests are passing and mypy strict passes. None of our samplers are tested up to the standard that @jsoules...