Bob Carpenter

Results 667 comments of Bob Carpenter

The branch doesn't build for me in doxygen. Could I have the wrong version of doxygen installed? ``` ~/github/stan-dev/cmdstan/stan/lib/stan_math (fix/docs1)$ doxygen --version 1.9.3 ``` Here's the error dump from doxygen:...

Awesome. It works now with only some config warnings. Should I go ahead and review and merge? ``` ~/github/stan-dev/cmdstan/stan/lib/stan_math (fix/docs1)$ make -j8 doxygen mkdir -p doc/api doxygen -v 1.9.3 doxygen...

It looks like the error may be on Jenkins config. I don't know how to mechanically do the review here. The 400+ files just chokes my web browser and the...

Thanks, @SteveBronder---that works. Now onto the actual reviewing.

Seriously, you can take as much of that feedback as you want. It's great as it is, and I wouldn't want to block it on grammar, formatting, etc.

Thanks, @Franzi2114. I can help with some of the questions: * if there's a variable precision algorithm that's really costly as precision goes up, then the most friendly API makes...

Sorry for not answering sooner, but I've been traveling. > how is the way to define defaults for our new function? Stan doesn't have a notion of default arguments or...

@Franzi2114: The former, but PRs can be modified as much as you want before they're merged. You just push new commits to your branch. I'd suggest reading some introductions to...

Thanks @bnicenboim. As a general rule, we should do whatever Higham recommends (his [blog on numerical analysis](https://nhigham.com/blog/) is fantastic)! We're using his matrix exponential function algorithm, too. Our log-sum-exp function...

We're also not computing the derivatives optimally according to that paper. I'll also fix that. Another question: is it OK if I change the boundary condition? Right now, log-sum-exp applied...