Braeden
Braeden
Unless this issue has been resolved elsewhere, I'd like to tackle it. As I understand from this thread, I may be able to fix the bug simply by properly handling...
It looks like this bug was fixed in commit https://github.com/freedomofpress/securedrop/commit/8ff264dbfc23bc34173f4d43527641afac6fc5d8 after this thread went silent. Specifically, [these lines](https://github.com/freedomofpress/securedrop/blob/8ff264dbfc23bc34173f4d43527641afac6fc5d8/securedrop/encryption.py#L86-#L90) catch any `GpgKeyNotFoundError` when a deletion attempt is made. I have not...
After making the linter's suggested changes, it still takes issue with that line, suggesting I change it to be... exactly the same? ```diff --- /root/project/dangerzone/errors.py 2024-06-12 15:36:20.384450+00:00 +++ /root/project/dangerzone/errors.py 2024-06-12...
> I just realized that `pathvalidate` is not in the standard python library, and this changes my thoughts. That's why I was also uncertain about using it :) Could you...
After syncing my branch with the main dev branch, two new test failures are occurring. A conversion error in Bookworm for the `sample-hwp.hwp` test: ``` ERROR dangerzone.isolation_provider.base:base.py:170 [doc z1s5Yj] 0%...
Currently, the commit is throwing an exception on the following test in Windows: ``` filename = 'D:\\a\\dangerzone\\dangerzone\\something_else.pdf' ``` This indicates a challenge with the validation structure. `validate_output_filename()`, which I modified,...
I'll see what I can do!
The GUI should now inform users of illegal characters in the output safe extension, and prevent conversion until the characters are removed. However, the commit is still failing a number...
That all makes sense. I don't have time at the moment, but I should be able to implement the suggestions you made in the next couple of weeks.
Hi @almet , I'm implementing the suggestions made by @apyrgio . I'll let you know if I run into any issues.