Brandon Williams

I haven't taken a look at this yet, but I would strongly encourage you to not use rocket. We already have a number of web frameworks in use and rocket...

I think that we should do as much as we can to do onchain verification of this data, although in addition to that we should also teach our validator software...

> I'm not exactly sure how best to block the transaction kind outside of tests without a CFG check. You can explicitly return an error in the gRPC interface in...

> > authority_server > > > > @bmwill, I imagine this would be in `handle_transaction`? > > > > What errors do we expect to emit for things that are...

No need to add more if you feel confident with the checks you've added

I don't have the full context here but this example is sort of confusing to me: ``` test@sui -> test.sui test@test -> test.test.sui ```

Thanks @lxfind and @mystenmark for the initial review on this. I'm not planning on getting this merged immediately, specifically i want to implement that client side as well as add...

@lxfind @mystenmark This is ready for review again, when you have the time

Thanks @jun0tpyrc for the report, we've also noticed this and are investigating.

> Thanks! Should we review sui-sdk first and get it into mysten repositories? Just moved this repo to mystenlabs/sui-rust-sdk and setup CI/branch protections and the like there.