Benjamin Muschko

Results 250 comments of Benjamin Muschko

I started by added the equivalent of `PlayContinuousBuildIntegrationTest` to get started: https://github.com/gradle/gradle/pull/8962

[Tried it out](https://travis-ci.org/gradle/play/jobs/462267454) but Travis CI doesn't seem to support Java builds on Windows. ``` The language 'java' is currently unsupported on the Windows Build Environment. Let us know if...

Maybe because we are explicitly using SLF4J in `PlayRun`? https://github.com/gradle/play/blob/master/src/main/java/com/playframework/gradle/tasks/PlayRun.java#L25-L26. Might be better to use the Gradle logger anyway.

You may want to review this again. Maybe I am overly cautious with the remaining use of `afterEvaluate`. Potentially we can avoid some of it through additional `Provider` API usage.

I think at least 1. would be a little awkward as you'd either have to know the full dependency notation with its variant or use the method that can prepare...

Now that those classes have been moved to `tools.internal` is there anything you'd expect to be done here?

@erdi is correct. `KickStart` and `DevAppServer` do not support setting a classpath directly. We discussed this before in [this issue](https://github.com/bmuschko/gradle-gae-plugin/issues/15). Not sure how the Maven plugin does this. I'd need...

Seems like your Docker daemon runs on a different machine? Have you tried connecting via HTTPS?

If you are dealing with just a single registry then you do not need to use `registryCredentials` for tasks. Simply define it centrally in the `docker` extension. It will be...

Sounds like a good idea. Would you be interested in providing a pull request?