Ben Straub
Ben Straub
@barnett11 many thanks for picking this up from our documentation. @jeffreyad is going to update the code, but could we put you down as a reviewer of the Pull Request?
> > @bundfussr should we add tests checking that the relationship argument works within our functions. > > Yes, some snapshot checks for the error messages would be nice. >...
> > @sophie-gem can you also implement a few simple tests for the relationship arguments just so we know they work/don't work > > Hi @bms63, apologies but I don't...
@sophie-gem I added a few snapshots tests in - they make testing a lot simpler. Do check it out when you have the time.
I got a couple of tests in - but ran out of time and of low quality. We can write new tests for 1.2.0 as this caused us to dip...
Could we try and get this out for the release? Any takers @pharmaverse/admiral @pharmaverse/admiral_comm
Are you able to complete this issue this week? We have a release on June 2nd.
> I guess my question is; Should AVALC (e.g. in ADEG) look more like this: > >  > > Or more like this: ![Screenshot...
@manciniedoardo if this satisfies your requirements then can your approve and merge in? @bundfussr apologies for my ignorance and not being a help here. my only concern is that if...